ifesdjeen commented on code in PR #4460:
URL: https://github.com/apache/cassandra/pull/4460#discussion_r2486683124
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -190,15 +186,9 @@ public synchronized void start()
{
Invariants.require(state == State.INITIALIZED, "Expected state to be
INITIALIZED but was %s", state);
state = State.STARTED;
-
- if (removedNodes != null)
- {
- // for all nodes removed, or pending removal, mark them as
removed, so we don't wait on their replies
- removedNodes.forEach(removed -> {
- onNodeRemoved(removed.removedIn.getEpoch(), currentTopology(),
new Node.Id(removed.id.id()));
- });
- removedNodes = null;
- }
+ endpointMapper.removedNodes().forEach((removed, removedIn) -> {
+ onNodeRemoved(removedIn, new Node.Id(removed.id));
Review Comment:
of course! if you could pick this up in one of the follow up patches that
would be just fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
