absurdfarce commented on code in PR #2060:
URL:
https://github.com/apache/cassandra-java-driver/pull/2060#discussion_r2487123163
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestIdGenerator.java:
##########
@@ -67,6 +67,10 @@ default String getCustomPayloadKey() {
default Statement<?> getDecoratedStatement(
@NonNull Statement<?> statement, @NonNull String requestId) {
+ // in case of retry or speculative execution
+ if (statement.getCustomPayload().containsKey(getCustomPayloadKey())) {
Review Comment:
Retries or speculative execution attempts are ideally supposed to be the
same (unmodified) content that went out the first time... kinda makes sense
given the role those two features play in the driver. With that in mind I
_assume_ you'd want to have the same ID here so that the retry or speculative
execution attempt could be more easily identified as what they are and not
mistaken for other follow-up requests from the driver.
@SiyaoIsHiding can confirm if that's what she was after here or not but that
_seems_ right to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
