bdeggleston commented on code in PR #4449:
URL: https://github.com/apache/cassandra/pull/4449#discussion_r2487616484
##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -1555,15 +1585,15 @@ public static void mutateAtomically(List<Mutation>
mutations,
else
writeMetrics.remoteRequests.mark();
- WriteResponseHandlerWrapper wrapper =
wrapBatchResponseHandler(normalMutation,
+ WriteResponseHandlerWrapper wrapper =
wrapBatchResponseHandler(untrackedMutation,
dataReplicaPlan,
batchConsistencyLevel,
WriteType.BATCH,
cleanup,
requestTime);
wrappers.add(wrapper);
};
- splitMutationsIntoAccordAndNormal(cm, mutations,
splitConsumer);
+ ConsensusMigrationMutationHelper.splitMutations(cm, mutations,
splitConsumer);
attributeNonAccordLatency = !wrappers.isEmpty();
cleanup.setMutationsWaitingFor(wrappers.size() +
(accordMutations.isEmpty() ? 0 : 1));
Tracing.trace("Split batch into Accord {} and normal {}",
accordMutations, wrappers);
Review Comment:
I agree we should do this, but I think it's best to leave it for when we add
logged batch support. Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
