sklaha commented on code in PR #272:
URL: https://github.com/apache/cassandra-sidecar/pull/272#discussion_r2493023958
##########
adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraCompactionManagerOperations.java:
##########
@@ -53,4 +55,27 @@ public List<Map<String, String>> getCompactions()
return jmxClient.proxy(CompactionManagerJmxOperations.class,
COMPACTION_MANAGER_OBJ_NAME)
.getCompactions();
}
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void stopCompaction(String compactionId, String compactionType)
Review Comment:
I would prefer to have two separate methods for compaction operations based
on ID and type, rather than having a single method that accepts two parameters
and actually uses only one.
##########
integration-tests/src/integrationTest/org/apache/cassandra/sidecar/routes/CompactionStopIntegrationTest.java:
##########
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.routes;
+
+import java.util.concurrent.TimeUnit;
+
+import org.junit.jupiter.api.Test;
+
+import io.netty.handler.codec.http.HttpResponseStatus;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpResponseExpectation;
+import io.vertx.core.json.JsonObject;
+import io.vertx.ext.web.client.HttpResponse;
+import org.apache.cassandra.sidecar.common.response.CompactionStopResponse;
+import org.apache.cassandra.sidecar.testing.QualifiedName;
+import
org.apache.cassandra.sidecar.testing.SharedClusterSidecarIntegrationTestBase;
+
+import static io.vertx.core.buffer.Buffer.buffer;
+import static org.apache.cassandra.testing.TestUtils.DC1_RF1;
+import static org.apache.cassandra.testing.TestUtils.TEST_KEYSPACE;
+import static org.apache.cassandra.testing.TestUtils.TEST_TABLE_PREFIX;
+import static org.apache.cassandra.testing.utils.AssertionUtils.getBlocking;
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Integration tests for the Compaction Stop API endpoint
+ */
+class CompactionStopIntegrationTest extends
SharedClusterSidecarIntegrationTestBase
Review Comment:
Can we add a test that triggers compaction and effectively stops ongoing
compactions using the API? You can get an idea of how to trigger a compaction
from the `testCompactionStatsRetrieval`.
https://github.com/apache/cassandra-sidecar/blob/c987f2956b22b457cf3ac68408657e706d0b9a1b/integration-tests/src/integrationTest/org/apache/cassandra/sidecar/routes/CassandraStatsIntegrationTest.java#L285
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/CompactionStopHandler.java:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.handlers;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+import com.google.inject.Inject;
+import io.netty.handler.codec.http.HttpResponseStatus;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.json.DecodeException;
+import io.vertx.core.json.Json;
+import io.vertx.core.net.SocketAddress;
+import io.vertx.ext.auth.authorization.Authorization;
+import io.vertx.ext.web.RoutingContext;
+import org.apache.cassandra.sidecar.acl.authorization.BasicPermissions;
+import
org.apache.cassandra.sidecar.common.request.data.CompactionStopRequestPayload;
+import org.apache.cassandra.sidecar.common.response.CompactionStopResponse;
+import org.apache.cassandra.sidecar.common.server.CompactionManagerOperations;
+import org.apache.cassandra.sidecar.concurrent.ExecutorPools;
+import org.apache.cassandra.sidecar.utils.CassandraInputValidator;
+import org.apache.cassandra.sidecar.utils.InstanceMetadataFetcher;
+import org.jetbrains.annotations.NotNull;
+
+import static
org.apache.cassandra.sidecar.utils.HttpExceptions.wrapHttpException;
+
+/**
+ * Handler for stopping compaction operations via the Cassandra Compaction
Manager.
+ *
+ * <p>Handles {@code POST /api/v1/cassandra/operations/compaction/stop}
requests to stop
+ * compaction operations. Expects a JSON payload with compaction_type and/or
compaction_id:
+ * <pre>
+ * { "compaction_type": "COMPACTION", "compaction_id": "abc-123" }
+ * </pre>
+ */
+public class CompactionStopHandler extends
AbstractHandler<CompactionStopRequestPayload> implements AccessProtected
+{
+ // Supported compaction types based on Cassandra's OperationType enum
+ private final Set<String> SUPPORTED_COMPACTION_TYPES =
Collections.unmodifiableSet(
+ new HashSet<>(Arrays.asList(
+ "COMPACTION",
+ "VALIDATION",
+ "KEY_CACHE_SAVE",
+ "ROW_CACHE_SAVE",
+ "COUNTER_CACHE_SAVE",
+ "CLEANUP",
+ "SCRUB",
+ "UPGRADE_SSTABLES",
+ "INDEX_BUILD",
+ "TOMBSTONE_COMPACTION",
+ "ANTICOMPACTION",
+ "VERIFY",
+ "VIEW_BUILD",
+ "INDEX_SUMMARY",
+ "RELOCATE",
+ "GARBAGE_COLLECT",
+ "WRITE"
+ ))
+ );
+
+ /**
+ * Constructs a handler with the provided {@code metadataFetcher}
+ *
+ * @param metadataFetcher the metadata fetcher
+ * @param executorPools executor pools for blocking executions
+ * @param validator validator for Cassandra-specific input
+ */
+ @Inject
+ protected CompactionStopHandler(final InstanceMetadataFetcher
metadataFetcher,
+ final ExecutorPools executorPools,
+ final CassandraInputValidator validator) {
+ super(metadataFetcher, executorPools, validator);
+ }
+
+ @Override
+ public Set<Authorization> requiredAuthorizations() {
+ return
Collections.singleton(BasicPermissions.MODIFY_COMPACTION.toAuthorization());
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void handleInternal(RoutingContext context,
+ HttpServerRequest httpRequest,
+ @NotNull String host,
+ SocketAddress remoteAddress,
+ CompactionStopRequestPayload request) {
+ CompactionManagerOperations compactionManagerOps =
metadataFetcher.delegate(host).compactionManagerOperations();
+
+ executorPools.service()
+ .executeBlocking(() -> stopCompaction(compactionManagerOps,
request))
+ .onSuccess(context::json)
+ .onFailure(cause -> processFailure(cause, context, host,
remoteAddress, request));
+ }
+
+ /**
+ * Stops the compaction based on the request parameters
+ *
+ * @param operations the compaction manager operations
+ * @param request the request payload containing compaction_type and/or
compaction_id
+ * @return CompactionStopResponse with the operation result
+ */
+ private CompactionStopResponse stopCompaction(CompactionManagerOperations
operations,
+ CompactionStopRequestPayload
request)
+ {
+ String compactionType = request.compactionType();
+ String compactionId = request.compactionId();
+
+ // Attempt to stop the compaction
+ operations.stopCompaction(compactionId, compactionType);
+
+ // Return success response
+ return CompactionStopResponse.builder()
+ .compactionType(compactionType)
+ .compactionId(compactionId)
+ .status("SUCCESS")
+ .errorCode("200 OK")
+ .reason("Operation Succeeded")
+ .build();
+ }
+
+ /**
+ * Override extractParamsOrThrow to support compactionStop param
constraints
+ * Method extracts and validates compaction stop request from routing
context
+ *
+ * @param context the routing context
+ * @return validated CompactionStopRequestPayload
+ */
+ @Override
+ protected CompactionStopRequestPayload extractParamsOrThrow(RoutingContext
context)
Review Comment:
Looks like compaction id takes precedence. It could be better to just fail
the request with appropriate error message.
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/CompactionStopHandler.java:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.handlers;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+import com.google.inject.Inject;
+import io.netty.handler.codec.http.HttpResponseStatus;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.json.DecodeException;
+import io.vertx.core.json.Json;
+import io.vertx.core.net.SocketAddress;
+import io.vertx.ext.auth.authorization.Authorization;
+import io.vertx.ext.web.RoutingContext;
+import org.apache.cassandra.sidecar.acl.authorization.BasicPermissions;
+import
org.apache.cassandra.sidecar.common.request.data.CompactionStopRequestPayload;
+import org.apache.cassandra.sidecar.common.response.CompactionStopResponse;
+import org.apache.cassandra.sidecar.common.server.CompactionManagerOperations;
+import org.apache.cassandra.sidecar.concurrent.ExecutorPools;
+import org.apache.cassandra.sidecar.utils.CassandraInputValidator;
+import org.apache.cassandra.sidecar.utils.InstanceMetadataFetcher;
+import org.jetbrains.annotations.NotNull;
+
+import static
org.apache.cassandra.sidecar.utils.HttpExceptions.wrapHttpException;
+
+/**
+ * Handler for stopping compaction operations via the Cassandra Compaction
Manager.
+ *
+ * <p>Handles {@code POST /api/v1/cassandra/operations/compaction/stop}
requests to stop
+ * compaction operations. Expects a JSON payload with compaction_type and/or
compaction_id:
+ * <pre>
+ * { "compaction_type": "COMPACTION", "compaction_id": "abc-123" }
+ * </pre>
+ */
+public class CompactionStopHandler extends
AbstractHandler<CompactionStopRequestPayload> implements AccessProtected
+{
+ // Supported compaction types based on Cassandra's OperationType enum
+ private final Set<String> SUPPORTED_COMPACTION_TYPES =
Collections.unmodifiableSet(
+ new HashSet<>(Arrays.asList(
+ "COMPACTION",
+ "VALIDATION",
+ "KEY_CACHE_SAVE",
+ "ROW_CACHE_SAVE",
+ "COUNTER_CACHE_SAVE",
+ "CLEANUP",
+ "SCRUB",
+ "UPGRADE_SSTABLES",
+ "INDEX_BUILD",
+ "TOMBSTONE_COMPACTION",
+ "ANTICOMPACTION",
+ "VERIFY",
+ "VIEW_BUILD",
+ "INDEX_SUMMARY",
+ "RELOCATE",
+ "GARBAGE_COLLECT",
+ "WRITE"
+ ))
+ );
+
+ /**
+ * Constructs a handler with the provided {@code metadataFetcher}
+ *
+ * @param metadataFetcher the metadata fetcher
+ * @param executorPools executor pools for blocking executions
+ * @param validator validator for Cassandra-specific input
+ */
+ @Inject
+ protected CompactionStopHandler(final InstanceMetadataFetcher
metadataFetcher,
+ final ExecutorPools executorPools,
+ final CassandraInputValidator validator) {
+ super(metadataFetcher, executorPools, validator);
+ }
+
+ @Override
+ public Set<Authorization> requiredAuthorizations() {
+ return
Collections.singleton(BasicPermissions.MODIFY_COMPACTION.toAuthorization());
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void handleInternal(RoutingContext context,
+ HttpServerRequest httpRequest,
+ @NotNull String host,
+ SocketAddress remoteAddress,
+ CompactionStopRequestPayload request) {
+ CompactionManagerOperations compactionManagerOps =
metadataFetcher.delegate(host).compactionManagerOperations();
+
+ executorPools.service()
+ .executeBlocking(() -> stopCompaction(compactionManagerOps,
request))
+ .onSuccess(context::json)
+ .onFailure(cause -> processFailure(cause, context, host,
remoteAddress, request));
+ }
+
+ /**
+ * Stops the compaction based on the request parameters
+ *
+ * @param operations the compaction manager operations
+ * @param request the request payload containing compaction_type and/or
compaction_id
+ * @return CompactionStopResponse with the operation result
+ */
+ private CompactionStopResponse stopCompaction(CompactionManagerOperations
operations,
+ CompactionStopRequestPayload
request)
+ {
+ String compactionType = request.compactionType();
+ String compactionId = request.compactionId();
+
+ // Attempt to stop the compaction
+ operations.stopCompaction(compactionId, compactionType);
+
+ // Return success response
+ return CompactionStopResponse.builder()
+ .compactionType(compactionType)
+ .compactionId(compactionId)
+ .status("SUCCESS")
+ .errorCode("200 OK")
+ .reason("Operation Succeeded")
+ .build();
Review Comment:
Do we need these fields? Doesn't HTTP 200 response provide the same
information? Also, these fields being set for failure scenarios.
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/CompactionStopHandler.java:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.handlers;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+import com.google.inject.Inject;
+import io.netty.handler.codec.http.HttpResponseStatus;
+import io.vertx.core.http.HttpServerRequest;
+import io.vertx.core.json.DecodeException;
+import io.vertx.core.json.Json;
+import io.vertx.core.net.SocketAddress;
+import io.vertx.ext.auth.authorization.Authorization;
+import io.vertx.ext.web.RoutingContext;
+import org.apache.cassandra.sidecar.acl.authorization.BasicPermissions;
+import
org.apache.cassandra.sidecar.common.request.data.CompactionStopRequestPayload;
+import org.apache.cassandra.sidecar.common.response.CompactionStopResponse;
+import org.apache.cassandra.sidecar.common.server.CompactionManagerOperations;
+import org.apache.cassandra.sidecar.concurrent.ExecutorPools;
+import org.apache.cassandra.sidecar.utils.CassandraInputValidator;
+import org.apache.cassandra.sidecar.utils.InstanceMetadataFetcher;
+import org.jetbrains.annotations.NotNull;
+
+import static
org.apache.cassandra.sidecar.utils.HttpExceptions.wrapHttpException;
+
+/**
+ * Handler for stopping compaction operations via the Cassandra Compaction
Manager.
+ *
+ * <p>Handles {@code POST /api/v1/cassandra/operations/compaction/stop}
requests to stop
+ * compaction operations. Expects a JSON payload with compaction_type and/or
compaction_id:
+ * <pre>
+ * { "compaction_type": "COMPACTION", "compaction_id": "abc-123" }
+ * </pre>
+ */
+public class CompactionStopHandler extends
AbstractHandler<CompactionStopRequestPayload> implements AccessProtected
+{
+ // Supported compaction types based on Cassandra's OperationType enum
+ private final Set<String> SUPPORTED_COMPACTION_TYPES =
Collections.unmodifiableSet(
+ new HashSet<>(Arrays.asList(
+ "COMPACTION",
+ "VALIDATION",
+ "KEY_CACHE_SAVE",
+ "ROW_CACHE_SAVE",
+ "COUNTER_CACHE_SAVE",
+ "CLEANUP",
+ "SCRUB",
+ "UPGRADE_SSTABLES",
+ "INDEX_BUILD",
+ "TOMBSTONE_COMPACTION",
+ "ANTICOMPACTION",
+ "VERIFY",
+ "VIEW_BUILD",
+ "INDEX_SUMMARY",
+ "RELOCATE",
+ "GARBAGE_COLLECT",
+ "WRITE"
+ ))
+ );
+
+ /**
+ * Constructs a handler with the provided {@code metadataFetcher}
+ *
+ * @param metadataFetcher the metadata fetcher
+ * @param executorPools executor pools for blocking executions
+ * @param validator validator for Cassandra-specific input
+ */
+ @Inject
+ protected CompactionStopHandler(final InstanceMetadataFetcher
metadataFetcher,
+ final ExecutorPools executorPools,
+ final CassandraInputValidator validator) {
+ super(metadataFetcher, executorPools, validator);
+ }
+
+ @Override
+ public Set<Authorization> requiredAuthorizations() {
+ return
Collections.singleton(BasicPermissions.MODIFY_COMPACTION.toAuthorization());
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void handleInternal(RoutingContext context,
+ HttpServerRequest httpRequest,
+ @NotNull String host,
+ SocketAddress remoteAddress,
+ CompactionStopRequestPayload request) {
+ CompactionManagerOperations compactionManagerOps =
metadataFetcher.delegate(host).compactionManagerOperations();
+
+ executorPools.service()
+ .executeBlocking(() -> stopCompaction(compactionManagerOps,
request))
+ .onSuccess(context::json)
+ .onFailure(cause -> processFailure(cause, context, host,
remoteAddress, request));
+ }
+
+ /**
+ * Stops the compaction based on the request parameters
+ *
+ * @param operations the compaction manager operations
+ * @param request the request payload containing compaction_type and/or
compaction_id
+ * @return CompactionStopResponse with the operation result
+ */
+ private CompactionStopResponse stopCompaction(CompactionManagerOperations
operations,
+ CompactionStopRequestPayload
request)
+ {
+ String compactionType = request.compactionType();
+ String compactionId = request.compactionId();
+
+ // Attempt to stop the compaction
+ operations.stopCompaction(compactionId, compactionType);
+
+ // Return success response
+ return CompactionStopResponse.builder()
+ .compactionType(compactionType)
+ .compactionId(compactionId)
+ .status("SUCCESS")
+ .errorCode("200 OK")
+ .reason("Operation Succeeded")
+ .build();
+ }
+
+ /**
+ * Override extractParamsOrThrow to support compactionStop param
constraints
+ * Method extracts and validates compaction stop request from routing
context
+ *
+ * @param context the routing context
+ * @return validated CompactionStopRequestPayload
+ */
+ @Override
+ protected CompactionStopRequestPayload extractParamsOrThrow(RoutingContext
context)
Review Comment:
What happens when the request has both compaction id and compaction type?
##########
integration-tests/src/integrationTest/org/apache/cassandra/sidecar/routes/CompactionStopIntegrationTest.java:
##########
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.routes;
+
+import java.util.concurrent.TimeUnit;
+
+import org.junit.jupiter.api.Test;
+
+import io.netty.handler.codec.http.HttpResponseStatus;
+import io.vertx.core.buffer.Buffer;
+import io.vertx.core.http.HttpResponseExpectation;
+import io.vertx.core.json.JsonObject;
+import io.vertx.ext.web.client.HttpResponse;
+import org.apache.cassandra.sidecar.common.response.CompactionStopResponse;
+import org.apache.cassandra.sidecar.testing.QualifiedName;
+import
org.apache.cassandra.sidecar.testing.SharedClusterSidecarIntegrationTestBase;
+
+import static io.vertx.core.buffer.Buffer.buffer;
+import static org.apache.cassandra.testing.TestUtils.DC1_RF1;
+import static org.apache.cassandra.testing.TestUtils.TEST_KEYSPACE;
+import static org.apache.cassandra.testing.TestUtils.TEST_TABLE_PREFIX;
+import static org.apache.cassandra.testing.utils.AssertionUtils.getBlocking;
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Integration tests for the Compaction Stop API endpoint
+ */
+class CompactionStopIntegrationTest extends
SharedClusterSidecarIntegrationTestBase
+{
+ private static final String COMPACTION_STOP_ROUTE =
"/api/v1/cassandra/operations/compaction/stop";
+ private static final QualifiedName TEST_TABLE = new
QualifiedName(TEST_KEYSPACE, TEST_TABLE_PREFIX + "_compaction_test");
+
+ @Override
+ protected void initializeSchemaForTest()
+ {
+ createTestKeyspace(TEST_KEYSPACE, DC1_RF1);
+ createTestTable(TEST_TABLE,
+ "CREATE TABLE %s ( \n" +
+ " id int PRIMARY KEY, \n" +
+ " data text \n" +
+ ");");
+ }
+
+ @Override
+ protected void beforeTestStart()
+ {
+ // Wait for schema initialization
+ waitForSchemaReady(30, TimeUnit.SECONDS);
+ }
+
+ @Test
+ void testStopCompactionByTypeSuccess()
+ {
+ // Create SSTables
+ insertTestData(TEST_TABLE, 1000);
+ cluster.stream().forEach(instance -> instance.flush(TEST_KEYSPACE));
+
+ // Trigger non-blocking compaction in background
+ cluster.stream().forEach(instance -> instance.nodetool("compact",
TEST_KEYSPACE));
+
+ // Call compaction stop endpoint
+ String payload = "{\"compaction_type\":\"COMPACTION\"}";
+ HttpResponse<Buffer> response = getBlocking(
+ trustedClient()
+ .post(serverWrapper.serverPort, "localhost",
COMPACTION_STOP_ROUTE)
+ .sendBuffer(buffer(payload))
+ .expecting(HttpResponseExpectation.SC_OK)
+ );
+
+
assertThat(response.statusCode()).isEqualTo(HttpResponseStatus.OK.code());
+ CompactionStopResponse stopResponse =
response.bodyAsJson(CompactionStopResponse.class);
+ assertThat(stopResponse).isNotNull();
+ assertThat(stopResponse.status()).isEqualTo("SUCCESS");
+ assertThat(stopResponse.compactionType()).isEqualTo("COMPACTION");
+ assertThat(stopResponse.errorCode()).isEqualTo("200 OK");
+ assertThat(stopResponse.reason()).isEqualTo("Operation Succeeded");
+ }
+
+ @Test
+ void testStopCompactionByIdSuccess()
Review Comment:
In the current implementation, a request with a non-existent compaction ID
silently succeeds. The JMX call simply succeeds without any action being taken.
It would be more informative to update the Cassandra JMX implementation to
return a boolean value or some other indicator. I will seek input from others
on this.
https://github.pie.apple.com/slaha/aci-cassandra/blob/38ab7d02e0979074f3de1c7f90ce70668d2492b9/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L2306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
