absurdfarce commented on code in PR #2060:
URL:
https://github.com/apache/cassandra-java-driver/pull/2060#discussion_r2501771085
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestIdGenerator.java:
##########
@@ -67,6 +67,10 @@ default String getCustomPayloadKey() {
default Statement<?> getDecoratedStatement(
@NonNull Statement<?> statement, @NonNull String requestId) {
+ // in case of retry or speculative execution
+ if (statement.getCustomPayload().containsKey(getCustomPayloadKey())) {
Review Comment:
To close the loop on this: the [level 2 trace-context
spec](https://www.w3.org/TR/trace-context-2/) is [pretty
clear](https://www.w3.org/TR/trace-context-2/#uniqueness-of-span-id) on this
point:
> The value of span-id SHOULD be unique within a [distributed
trace](https://www.w3.org/TR/trace-context-2/#dfn-distributed-traces). If the
value of span-id is not unique within a distributed trace, parent-child
relationships between spans within the distributed trace may be ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
