absurdfarce commented on code in PR #304: URL: https://github.com/apache/cassandra-website/pull/304#discussion_r2517248405
########## site-content/source/modules/ROOT/pages/download.adoc: ########## @@ -92,10 +92,9 @@ https://www.apache.org/dyn/closer.lua/cassandra/4.0.19/apache-cassandra-4.0.19-b ==== Apache 4.x Java driver for Cassandra [.btn.btn--alt] -https://www.apache.org/dyn/closer.lua/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1.tar.gz[4.19.1,window=blank] +https://www.apache.org/dyn/closer.lua/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz[4.19.1,window=blank] -(https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1.tar.gz.asc[pgp,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1.tar.gz.sha256[sha256,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1.tar.gz.sha512[sha512,window=blank]) + -(https://www.apache.org/dyn/closer.lua/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz[source,window=blank]: https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.asc[pgp,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.sha256[sha256,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.sha512[sha512,window=blank]) +(https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.asc[pgp,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.sha256[sha256,window=blank], https://downloads.apache.org/cassandra/cassandra-java-driver/4.19.1/apache-cassandra-java-driver-4.19.1-source.tar.gz.sha512[sha512,window=blank]) + Review Comment: The format that was used here is identical to what's used with the Go driver just below it; I literally copied that block and updated the URLs. I'm happy to update the links to add a leading "source:" before the links to the various checksums but it's also worth pointing out that it isn't the case that everything else on this page downloads a binary artifact. That's what I was getting at when I mentioned that my proposal wound up making the Java driver look a lot like the Go driver in terms of how it's represented on this download page. In unrelated news: if we're going to change to "www.apache.org/dyn/" for the source tarball do we not want to use the same structure for the checksum files? In that same vein: if we change to "www.apache.org/dyn/" am I correct in saying we'll want to do the same for the Go driver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
