frankgh commented on code in PR #276: URL: https://github.com/apache/cassandra-sidecar/pull/276#discussion_r2539761217
########## CHANGES.txt: ########## @@ -1,6 +1,7 @@ 0.3.0 ----- * Fast Cassandra Input Validator (CASSSIDECAR-361) + * Endpoint to invalidate auth caches as required (CASSSIDECAR-364) Review Comment: I suspect you need to rebase, but this entry should be at the top of the list ########## client-common/src/main/java/org/apache/cassandra/sidecar/common/request/InvalidateCacheRequest.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.common.request; + +import java.util.List; + +import io.netty.handler.codec.http.HttpMethod; +import org.apache.cassandra.sidecar.common.ApiEndpointsV1; +import org.apache.cassandra.sidecar.common.response.HealthResponse; +import org.jetbrains.annotations.Nullable; + +/** + * Represents a request to invalidate the specified cache + */ +public class InvalidateCacheRequest extends JsonRequest<HealthResponse> +{ + /** + * Constructs a request to execute cache invalidation operation + * + * @param cacheName the name of the cache to invalidate + * @param keys the specific keys to invalidate, or null to invalidate all keys + */ + public InvalidateCacheRequest(String cacheName, @Nullable List<String> keys) + { + super(buildRequestURI(cacheName, keys)); + } + + /** + * Builds the request URI with optional query parameters for specific keys + * + * @param cacheName the name of the cache to invalidate + * @param keys the specific keys to invalidate, or null to invalidate all keys + * @return the complete request URI with query parameters if keys are provided + */ + private static String buildRequestURI(String cacheName, @Nullable List<String> keys) + { + String baseUri = ApiEndpointsV1.INVALIDATE_CACHE_ROUTE + .replaceAll(ApiEndpointsV1.CACHE_NAME_PARAM, cacheName); + + if (keys == null || keys.isEmpty()) + { + return baseUri; + } + + StringBuilder uri = new StringBuilder(baseUri).append('?'); + for (int i = 0; i < keys.size(); i++) + { + if (i > 0) + { + uri.append('&'); + } + uri.append("keys=").append(keys.get(i)); Review Comment: we might need to url encode these values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
