smiklosovic commented on PR #4492:
URL: https://github.com/apache/cassandra/pull/4492#issuecomment-3569949395

   I am not completely sure about 
   
   for (ReferenceOperation operation : operations.allSubstitutions())
   
   refactoring, there is some additional logic for that method. But what 
requiresRead() method in Operations is doing is that it will iterate over 
`this` and iterator is going through both static and regular 
   
       @Override
       public Iterator<Operation> iterator()
       {
           return Iterators.concat(staticOperations.iterator(), 
regularOperations.iterator());
       }
   
   
   so it should be ok but needs to be double checked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to