smiklosovic commented on code in PR #4487:
URL: https://github.com/apache/cassandra/pull/4487#discussion_r2556068004
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -803,6 +809,21 @@ public static void registerNativeAccess() throws
javax.management.NotCompliantMB
MBeanWrapper.instance.registerMBean(new StandardMBean(new
NativeAccess(), NativeAccessMBean.class), MBEAN_NAME,
MBeanWrapper.OnException.LOG);
}
+ @VisibleForTesting
+ public static void registerAsyncProfiler() throws
javax.management.NotCompliantMBeanException
+ {
+ AsyncProfiler asyncProfiler;
+ if (!ASYNC_PROFILER_ADVANCED_MODE.getBoolean())
Review Comment:
@bbotella would not it be better if this was called `ASYNC_PROFILER_UNSAFE`?
I do not know what "advanced"
means.
This seems to be way more straightforward.
`AsyncProfiler asyncProfiler = ASYNC_PROFILER_UNSAFE.getBoolean() ? new
AsyncProfilerUnsafe() : new AsyncProfilerSafe()`
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -803,6 +809,21 @@ public static void registerNativeAccess() throws
javax.management.NotCompliantMB
MBeanWrapper.instance.registerMBean(new StandardMBean(new
NativeAccess(), NativeAccessMBean.class), MBEAN_NAME,
MBeanWrapper.OnException.LOG);
}
+ @VisibleForTesting
+ public static void registerAsyncProfiler() throws
javax.management.NotCompliantMBeanException
+ {
+ AsyncProfiler asyncProfiler;
+ if (!ASYNC_PROFILER_ADVANCED_MODE.getBoolean())
Review Comment:
@bbotella would not it be better if this was called `ASYNC_PROFILER_UNSAFE`?
I do not know what "advanced"
means.
This seems to be way more straightforward.
`AsyncProfiler asyncProfiler = ASYNC_PROFILER_UNSAFE.getBoolean() ? new
AsyncProfilerUnsafe() : new AsyncProfilerSafe();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
