beobal commented on code in PR #4495:
URL: https://github.com/apache/cassandra/pull/4495#discussion_r2567505763
##########
src/java/org/apache/cassandra/db/marshal/UserType.java:
##########
@@ -413,11 +413,18 @@ private boolean equalsWithoutTypes(UserType other)
return name.equals(other.name)
&& fieldNames.equals(other.fieldNames)
&& keyspace.equals(other.keyspace)
- && isMultiCell == other.isMultiCell;
+ && isMultiCell == other.isMultiCell
+ && comment.equals(other.comment)
+ && securityLabel.equals(other.securityLabel)
+ && fieldComments.equals(other.fieldComments)
+ && fieldSecurityLabels.equals(other.fieldSecurityLabels);
}
public boolean equalsWithOutKs(UserType other)
{
+ // Doesn't consider consider comments or security labels at either the
Review Comment:
oops, will fix on commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
