yifan-c commented on code in PR #4510:
URL: https://github.com/apache/cassandra/pull/4510#discussion_r2582872613
##########
test/unit/org/apache/cassandra/db/compression/CompressionDictionarySchedulerTest.java:
##########
@@ -43,8 +43,6 @@ public class CompressionDictionarySchedulerTest extends
CQLTester
public void setUp()
{
cache = new CompressionDictionaryCache();
- // Disable compaction to make the sstable sampling deterministic; to
avoid excluding sstables get compacted away.
- disableCompaction(KEYSPACE);
Review Comment:
At the moment, the table is not yet created. This method does nothing. So
removing it.
##########
test/unit/org/apache/cassandra/db/compression/CompressionDictionarySchedulerTest.java:
##########
@@ -83,6 +81,7 @@ public void testScheduleSSTableBasedTrainingWithSSTables()
scheduler = new CompressionDictionaryScheduler(KEYSPACE, table, cache,
true);
ColumnFamilyStore cfs =
Keyspace.open(keyspace()).getColumnFamilyStore(table);
+ cfs.disableAutoCompaction();
Review Comment:
need to disable compaction only after table is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
