netudima commented on code in PR #4512:
URL: https://github.com/apache/cassandra/pull/4512#discussion_r2585742868
##########
src/java/org/apache/cassandra/metrics/ThreadLocalMeter.java:
##########
@@ -92,9 +93,21 @@ public class ThreadLocalMeter extends
com.codahale.metrics.Meter implements Mete
maxTicks = m3Ticks;
}
+ private static final ScheduledFuture<?> backgroundTickingJob;
+
+ /**
+ * the method is provided for test purposes only,
+ * to disable background activities and make tests more deterministic
+ */
+ @VisibleForTesting
+ public static void disableBackgroundTicking()
Review Comment:
I think package private method is a slightly better option here..
1) it is a bit better encapsulated vs exposing a field for any actions with
it
2) the method name self-documents the reason to expose more explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
