aratno commented on code in PR #4445: URL: https://github.com/apache/cassandra/pull/4445#discussion_r2585866514
########## src/java/org/apache/cassandra/metrics/MutationTrackingMetrics.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.metrics; + +import com.codahale.metrics.Counter; +import com.codahale.metrics.Gauge; +import com.codahale.metrics.Histogram; +import org.apache.cassandra.replication.MutationJournal; +import org.apache.cassandra.replication.MutationTrackingService; + +import static org.apache.cassandra.metrics.CassandraMetricsRegistry.Metrics; + +public class MutationTrackingMetrics +{ + public static final String TYPE_NAME = "MutationTracking"; + private static final MetricNameFactory factory = new DefaultNameFactory(TYPE_NAME); + + public static final MutationTrackingMetrics instance = new MutationTrackingMetrics(); + + public final Counter broadcastOffsetsDiscovered; // Newly-witnessed offsets discovered via broadcast + public final Counter writeTimeOffsetsDiscovered; // Newly-witnessed offsets discovered at write time + public final Histogram readSummarySize; // Read summary sizes + public final Gauge<Long> unreconciledMutationCount; // Number of unreconciled mutations + public final Gauge<Long> journalDiskSpaceUsed; // Size of MutationJournal on disk + + @SuppressWarnings("Convert2MethodRef") + private MutationTrackingMetrics() + { + broadcastOffsetsDiscovered = Metrics.counter(factory.createMetricName("broadcastOffsetsDiscovered")); + writeTimeOffsetsDiscovered = Metrics.counter(factory.createMetricName("WriteTimeOffsetsDiscovered")); + readSummarySize = Metrics.histogram(factory.createMetricName("ReadSummarySize"), false); Review Comment: Might be clearer to have considerZeroes true, to differentiate between empty and non-empty summaries ########## src/java/org/apache/cassandra/metrics/MutationTrackingMetrics.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.metrics; + +import com.codahale.metrics.Counter; +import com.codahale.metrics.Gauge; +import com.codahale.metrics.Histogram; +import org.apache.cassandra.replication.MutationJournal; +import org.apache.cassandra.replication.MutationTrackingService; + +import static org.apache.cassandra.metrics.CassandraMetricsRegistry.Metrics; + +public class MutationTrackingMetrics +{ + public static final String TYPE_NAME = "MutationTracking"; + private static final MetricNameFactory factory = new DefaultNameFactory(TYPE_NAME); + + public static final MutationTrackingMetrics instance = new MutationTrackingMetrics(); + + public final Counter broadcastOffsetsDiscovered; // Newly-witnessed offsets discovered via broadcast + public final Counter writeTimeOffsetsDiscovered; // Newly-witnessed offsets discovered at write time + public final Histogram readSummarySize; // Read summary sizes + public final Gauge<Long> unreconciledMutationCount; // Number of unreconciled mutations + public final Gauge<Long> journalDiskSpaceUsed; // Size of MutationJournal on disk + + @SuppressWarnings("Convert2MethodRef") + private MutationTrackingMetrics() + { + broadcastOffsetsDiscovered = Metrics.counter(factory.createMetricName("broadcastOffsetsDiscovered")); Review Comment: Nit ```suggestion broadcastOffsetsDiscovered = Metrics.counter(factory.createMetricName("BroadcastOffsetsDiscovered")); ``` ########## src/java/org/apache/cassandra/replication/MutationTrackingService.java: ########## @@ -330,7 +331,9 @@ public MutationSummary createSummaryForKey(DecoratedKey key, TableId tableId, bo shardLock.readLock().lock(); try { - return getOrCreateShards(tableId).createSummaryForKey(key, tableId, includePending); + MutationSummary summary = getOrCreateShards(tableId).createSummaryForKey(key, tableId, includePending); + MutationTrackingMetrics.instance.readSummarySize.update(summary.size()); Review Comment: Should also apply to createSummaryForRange, so we measure summary sizes for range reads as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
