bbotella commented on code in PR #4487: URL: https://github.com/apache/cassandra/pull/4487#discussion_r2600300870
########## src/java/org/apache/cassandra/service/AsyncProfilerService.java: ########## @@ -0,0 +1,458 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.service; + +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.EnumSet; +import java.util.List; +import java.util.Optional; +import java.util.regex.Pattern; + +import javax.management.StandardMBean; + +import com.google.common.annotations.VisibleForTesting; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import one.profiler.AsyncProfiler; +import org.apache.cassandra.config.CassandraRelevantProperties; +import org.apache.cassandra.config.DatabaseDescriptor; +import org.apache.cassandra.config.DurationSpec; +import org.apache.cassandra.exceptions.ConfigurationException; +import org.apache.cassandra.io.util.File; +import org.apache.cassandra.profiler.AsyncProfilerMBean; +import org.apache.cassandra.utils.MBeanWrapper; + +import static java.lang.String.format; +import static java.util.stream.Collectors.toList; +import static org.apache.cassandra.config.CassandraRelevantProperties.ASYNC_PROFILER_ENABLED; +import static org.apache.cassandra.config.CassandraRelevantProperties.ASYNC_PROFILER_UNSAFE_MODE; +import static org.apache.cassandra.config.CassandraRelevantProperties.LOG_DIR; + +public class AsyncProfilerService implements AsyncProfilerMBean +{ + private static final Logger logger = LoggerFactory.getLogger(AsyncProfilerService.class); + + private static final EnumSet<AsyncProfilerEvent> VALID_EVENTS = EnumSet.allOf(AsyncProfilerEvent.class); + private static final EnumSet<AsyncProfilerFormat> VALID_FORMATS = EnumSet.allOf(AsyncProfilerFormat.class); + private static final Pattern VALID_FILENAME_REGEX_PATTERN = Pattern.compile("^[a-zA-Z0-9-]*\\.?[a-zA-Z0-9-]*$"); + private static final int MAX_SAFE_PROFILING_DURATION = 43200; // 12 hours + private static final String ASYNC_PROFILER_LOG_DIR = Path.of(LOG_DIR.getString(), "profiler").toString(); + + private static AsyncProfilerService instance; + private static AsyncProfiler asyncProfiler; + private final boolean unsafeMode; + private static String logDir; + + // logDir as a parameter to be used by tests. + public static synchronized AsyncProfilerService instance(String logDir) + { + AsyncProfilerService.logDir = logDir; + if (instance == null) + { + try + { + instance = new AsyncProfilerService(ASYNC_PROFILER_UNSAFE_MODE.getBoolean()); + asyncProfiler = instance.getProfiler().orElse(null); + if (ASYNC_PROFILER_ENABLED.getBoolean()) + { + // register mbean first, before initialisation, which might fail (e.g. profiler functionality is disabled) + MBeanWrapper.instance.registerMBean(new StandardMBean(AsyncProfilerService.instance, AsyncProfilerMBean.class), + AsyncProfilerService.MBEAN_NAME, + MBeanWrapper.OnException.LOG); + } + } + catch (Throwable t) + { + throw new RuntimeException(t); + } + } + return AsyncProfilerService.instance; + } + + public static synchronized AsyncProfilerService instance() + { + if (instance == null) + return instance(ASYNC_PROFILER_LOG_DIR); + else + return instance; + } + + public AsyncProfilerService(boolean unsafeMode) + { + this.unsafeMode = unsafeMode; + } + + public enum AsyncProfilerEvent + { + cpu("cpu"), + alloc("alloc"), + lock("lock"), + wall("wall"), + nativemem("nativemem"), + cache_misses("cache-misses"); + + private final String name; + + AsyncProfilerEvent(String name) + { + this.name = name; + } + + public String getEvent() + { + return name; + } + + public static String parseEvents(String rawString) + { + if (rawString == null || rawString.isBlank()) + throw new IllegalArgumentException("Event can not be null nor blank string."); + + try + { + List<String> processedEvents = new ArrayList<>(); + for (String rawEvent : rawString.split(",")) + processedEvents.add(AsyncProfilerEvent.valueOf(rawEvent).getEvent()); + + return String.join(",", processedEvents); + } + catch (IllegalArgumentException ex) + { + throw new IllegalArgumentException(format("Event must be one or a combination of %s", VALID_EVENTS)); + } + } + } + + public enum AsyncProfilerFormat + { + flat, traces, collapsed, flamegraph, tree, jfr; + + public static String parseFormat(String rawFormat) + { + if (rawFormat == null || rawFormat.isBlank()) + throw new IllegalArgumentException("Event can not be null nor blank string."); + + try + { + return AsyncProfilerFormat.valueOf(rawFormat).name(); + } + catch (IllegalArgumentException ex) + { + throw new IllegalArgumentException(format("Format must be one of %s", VALID_FORMATS)); + } + } + } + + @Override + public synchronized boolean start(String events, String outputFormat, String duration, String outputFileName) + { + if (isRunning()) + return false; + + try + { + run(new ThrowingFunction<>() + { + @Override + public Object apply(AsyncProfiler profiler) throws Throwable + { + String cmd = format("start,%s,event=%s,timeout=%s,file=%s", + AsyncProfilerFormat.parseFormat(outputFormat), + AsyncProfilerEvent.parseEvents(events), + parseDuration(duration), + new File(logDir, validateOutputFileName(outputFileName))); + + String result = profiler.execute(cmd); + logger.debug("Started Async-Profiler: result={}, cmd={}", result, cmd); + + return null; + } + }); + return true; + } + catch (IllegalStateException | IllegalArgumentException ex) + { + throw ex; + } + catch (Throwable t) + { + logger.error("Failed to start Async-Profiler", t); + return false; + } + } + + @Override + public synchronized boolean stop(String outputFileName) + { + if (!isRunning()) + return false; + + try + { + run(new ThrowingFunction<>() + { + @Override + public Object apply(AsyncProfiler profiler) throws Throwable + { + String cmd = "stop"; + if (outputFileName != null) + { + File outputFile = new File(logDir, validateOutputFileName(outputFileName)); + cmd += ",file=" + outputFile.absolutePath(); + } + + String result = profiler.execute(cmd); + logger.debug("Stopped Async-Profiler: result={}, cmd={}", result, cmd); + + return null; + } + }); + return true; + } + catch (IllegalStateException | IllegalArgumentException e) + { + throw e; + } + catch (Throwable e) + { + logger.error("Failed to stop Async-Profiler", e); + return false; + } + } + + @Override + public String execute(String command) + { + if (!unsafeMode) + { + throw new SecurityException(String.format("The arbitrary command execution is not permitted " + + "with %s MBean. If unsafe command execution is required, " + + "start Cassandra with %s property set to true. " + + "Rejected command: %s", + AsyncProfilerService.MBEAN_NAME, + CassandraRelevantProperties.ASYNC_PROFILER_UNSAFE_MODE.name(), command)); + } + + return run(new ThrowingFunction<AsyncProfiler, String>() + { + @Override + public String apply(AsyncProfiler profiler) throws Throwable + { + return profiler.execute(validateCommand(command)); + } + }); + } + + @Override + public List<String> list() + { + try + { + createLogDir(); + return Arrays.stream(new File(logDir).list()).map(File::name).sorted().collect(toList()); + } + catch (Throwable t) + { + return List.of(); + } + } + + @Override + public byte[] fetch(String resultFile) + { + try + { + createLogDir(); + return Files.readAllBytes(new File(logDir, resultFile).toPath()); + } + catch (Throwable t) + { + logger.error("Result file " + resultFile + " not found or error occurred while returning it.", t); + throw new RuntimeException(t); + } + } + + @Override + public void purge() + { + createLogDir(); + new File(logDir).deleteRecursive(); + } + + @Override + public String status() + { + return run(new ThrowingFunction<>() + { + @Override + public String apply(AsyncProfiler asyncProfiler) throws Throwable + { + return asyncProfiler.execute("status"); + } + }); + } + + @Override + public boolean isEnabled() + { + return instance != null; + } + + public static String validateOutputFileName(String outputFile) + { + if (outputFile == null || outputFile.trim().isEmpty()) + throw new IllegalArgumentException("Output file name must not be null or empty."); + + if (!VALID_FILENAME_REGEX_PATTERN.matcher(outputFile).matches()) + throw new IllegalArgumentException(format("Output file name must match pattern %s", VALID_FILENAME_REGEX_PATTERN)); + + return outputFile; + } + + public static String validateCommand(String command) + { + if (command == null || command.isBlank()) + throw new IllegalArgumentException("Command can not be null or blank string"); + + return command; + } + + /** + * @param duration duration of profiling + * @return converted string representation of duration to seconds + */ + public static int parseDuration(String duration) + { + int durationSeconds = new DurationSpec.IntSecondsBound(duration).toSeconds(); Review Comment: The validation is done before on the Duration Spec class. It throws an `IllegalArgumentException` that is nicely handled by nodetool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
