dcapwell commented on code in PR #262:
URL: https://github.com/apache/cassandra-accord/pull/262#discussion_r2611524440
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -1126,7 +1138,7 @@ public Setup<State, SystemUnderTest> next(RandomSource rs)
for (Setup<State, SystemUnderTest> s :
unknownWeights)
weights.put(s,
unknownWeightGen.nextInt(rs));
}
- nonConditional = Gens.pick(weights);
+ nonConditional = weights.isEmpty() ? null :
Gens.pick(weights);
Review Comment:
found a bug in my other branch where weights was empty so we would fail as
we can't pick from an empty set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]