dcapwell commented on code in PR #4518:
URL: https://github.com/apache/cassandra/pull/4518#discussion_r2611539096
##########
src/java/org/apache/cassandra/batchlog/BatchlogManager.java:
##########
@@ -451,9 +453,12 @@ public void finish(Set<UUID> hintedNodes)
{
if (accordResult != null)
{
- TxnResult.Kind kind = accordResult.awaitAndGet().kind();
+ TxnResult result = accordResult.awaitAndGet();
+ TxnResult.Kind kind = result.kind();
if (kind == retry_new_protocol)
throw new RetryOnDifferentSystemException();
+ if (result.kind() == txn_data)
+ ((TxnData) result).checkAndThrowValidationException();
Review Comment:
thought about it more and i don't think this code path is actually possible.
We send `Mutation` to the batch so have already passed validation. We also
know its not the accord code path as `retry_new_protocol` tells batch we need
to reprocess as accord...
Ill remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
