frankgh commented on code in PR #303:
URL: https://github.com/apache/cassandra-sidecar/pull/303#discussion_r2621207233


##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/CassandraAdapterDelegate.java:
##########
@@ -645,12 +645,8 @@ public void handleNotification(Notification notification, 
Object handback)
                 switch (type)
                 {
                     case JMXConnectionNotification.OPENED:
-                        // Do not notify here as we may not have set up our 
own delegate yet
-                        // Instead, run the JMX Health Check, which will 
notify once we have
-                        // created or updated the adapter.
-                        jmxHealthCheck();
+                        LOGGER.info("JMX connection opened");

Review Comment:
   Can we move this to debug? We already log connections elsewhere and this 
would just be redundant.
   ```suggestion
                           LOGGER.debug("JMX connection opened");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to