maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2624343352
##########
src/java/org/apache/cassandra/index/sai/disk/format/IndexDescriptor.java:
##########
@@ -126,7 +127,10 @@ public PrimaryKeyMap.Factory
newPrimaryKeyMapFactory(SSTableReader sstable)
public SSTableIndex newSSTableIndex(SSTableContext sstableContext,
StorageAttachedIndex index)
{
- return version.onDiskFormat().newSSTableIndex(sstableContext, index);
+ if (isIndexEmpty(index.termType(), index.identifier()))
+ return index.termType().isVector() ? new
EmptyIndex(sstableContext, index) : null;
Review Comment:
Does returning `null` here subtly change what happens in the non-vector case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
