smiklosovic commented on code in PR #4535:
URL: https://github.com/apache/cassandra/pull/4535#discussion_r2631452465
##########
test/unit/org/apache/cassandra/db/compression/CompressionDictionaryIntegrationTest.java:
##########
@@ -134,7 +134,7 @@ public void testResourceCleanupOnClose() throws Exception
assertThat(testDict.selfRef().globalCount())
.as("Dictionary's reference count should be 1 after adding to cache")
- .isOne();
+ .isOne(); // TODO this fails, for some reason, this is "2" instead of
"1".
Review Comment:
if this assert is commented out and
spinUntilTrue(() -> testDict.selfRef().globalCount() == 0, 1,
TimeUnit.SECONDS);
is changed to
spinUntilTrue(() -> testDict.selfRef().globalCount() == 1, 1,
TimeUnit.SECONDS);
This test passes. So After manager is closed, there is still some reference
dangling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
