yifan-c commented on code in PR #299:
URL: https://github.com/apache/cassandra-sidecar/pull/299#discussion_r2632414448
##########
server/src/test/integration/org/apache/cassandra/sidecar/testing/BootstrapBBUtils.java:
##########
@@ -44,13 +44,44 @@ public class BootstrapBBUtils
public static void installFinishJoiningRingInterceptor(ClassLoader cl,
Class<?> interceptor)
{
TypePool typePool = TypePool.Default.of(cl);
- TypeDescription description =
typePool.describe("org.apache.cassandra.service.StorageService")
- .resolve();
- new ByteBuddy().rebase(description,
ClassFileLocator.ForClassLoader.of(cl))
+ if (installTcm(cl, typePool, interceptor) || installPreTcm(cl,
typePool, interceptor))
+ {
+ return;
+ }
+ throw new RuntimeException("Could not intercept node move");
Review Comment:
the message can be just "Could not intercept", which is clear already. There
are different methods can be intercepted. I think 'node move' was there for the
purpose of being general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
