aratno commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r2635875678
##########
src/java/org/apache/cassandra/concurrent/SEPWorker.java:
##########
@@ -128,8 +130,11 @@ public void run()
assigned = get().assigned;
if (assigned == null)
continue;
- if (SET_THREAD_NAME)
+ if (SET_THREAD_NAME && assigned.name != lastUsedExecutorName)
// equals is not used intentionally
Review Comment:
Bit of a nit, but:
```suggestion
if (SET_THREAD_NAME && assigned.name !=
lastUsedExecutorName) // .equals is not used intentionally
```
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
*/
SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
- SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+ SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),
Review Comment:
Can we make this a hot-prop so it can be toggled via JMX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
