jyothsnakonisa commented on code in PR #4538:
URL: https://github.com/apache/cassandra/pull/4538#discussion_r2636301259
##########
src/java/org/apache/cassandra/utils/btree/BTree.java:
##########
@@ -1316,6 +1317,55 @@ public static <I, O> Object[] transform(Object[] tree,
Function<? super I, ? ext
return result;
}
+ /**
Review Comment:
This method & transformLeaf is duplicating a lot of code. Do we have any
metrics on performance improvements? otherwise the duplication could cause
cause inconsistencies in code, maintenance issues and could create bugs.
##########
src/java/org/apache/cassandra/db/Columns.java:
##########
@@ -426,6 +427,11 @@ public void apply(Consumer<ColumnMetadata> function)
BTree.apply(columns, function);
}
+ public <V> void apply(BiConsumer<V, ColumnMetadata> function, V argument)
Review Comment:
This method is identical to other method ` public void
apply(Consumer<ColumnMetadata> function)`, does passing the argument improves
the performance and do you have any metrics to support that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
