smiklosovic commented on code in PR #4523: URL: https://github.com/apache/cassandra/pull/4523#discussion_r2637414165
########## doc/modules/cassandra/pages/managing/operating/compression.adoc: ########## @@ -298,12 +298,6 @@ next access. === Training Configuration -* `compression_dictionary_training_max_dictionary_size` (default: `65536`): -Maximum size of trained dictionaries in bytes. Larger dictionaries can -capture more patterns but increase memory overhead. -* `compression_dictionary_training_max_total_sample_size` (default: -`10485760`): Maximum total size of sample data to collect for training, -approximately 10MB. * `compression_dictionary_training_auto_train_enabled` (default: `false`): Enable automatic background dictionary training. When enabled, Cassandra samples writes and trains dictionaries automatically. Review Comment: it is supposed to be in the range of 0.01 - 1. Not 1 - 10000. But you are right the docs are not aligned, there are still places where we use 1 - 10000, that has to be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
