Yukei7 commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r2653566393
##########
src/java/org/apache/cassandra/service/GCInspector.java:
##########
@@ -308,9 +336,24 @@ else if (logger.isTraceEnabled())
}
else
{
- if (getGcWarnThresholdInMs() != 0 && duration >
getGcWarnThresholdInMs())
+ long warnThreshold;
+ long logThreshold;
+
+ if (gcState.isZGC && !gcState.assumeGCIsPartiallyConcurrent)
Review Comment:
I recently contributed a patch for GCInspector to take care of the
concurrent phase, and I believe both ZGC and Shenandoah has been taken care
properly there: https://issues.apache.org/jira/browse/CASSANDRA-20980
Let me know if this works for you! It feels like we don't need the change
for GCInspector here after 20980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
