dcapwell commented on code in PR #4537:
URL: https://github.com/apache/cassandra/pull/4537#discussion_r2674151566
##########
test/unit/org/apache/cassandra/service/RetryStrategyTest.java:
##########
@@ -64,6 +71,33 @@ public void fuzzParser()
});
}
+ @Test
+ public void testSeededWaitRandomizer()
Review Comment:
test name patterns are not controlled by the style guide, but one thing that
is is that we must be consistent within a file. The other test in this class
doesn't have the `test` prefix, so its best to exclude that prefix to be
consistent.
There are other test classes that have a `test` prefix, for those classes
you would want to keep it...
Its confusing, but the TL;DR - Try to be consistent with any existing
pattern with the file you are working with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
