pauloricardomg commented on code in PR #277:
URL: https://github.com/apache/cassandra-sidecar/pull/277#discussion_r2677623935
##########
server/src/main/java/org/apache/cassandra/sidecar/config/InstanceConfiguration.java:
##########
@@ -104,4 +105,9 @@ public interface InstanceConfiguration
* @return the password for the JMX role for the JMX service for the
Cassandra instance
*/
String jmxRolePassword();
+
+ /**
+ * @return The lifecycle options for this Cassandra instance
+ */
+ Map<String, String> lifecycleOptions();
Review Comment:
This is to allow supporting custom instance options for downstream
providers. For example, a HTTP-based lifecycle provider could have a different
control endpoint per instance that would be specified as a lifecycle option,
but this option would not make sense in a process lifecycle or docker provider.
This would not be possible if we have a strongly typed object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
