maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2677842793
##########
src/java/org/apache/cassandra/index/sai/disk/v1/vector/DiskAnn.java:
##########
@@ -86,13 +82,19 @@ public int size()
return graph.size();
}
+ public CompressedVectors getCompressedVectors()
+ {
+ return compressedVectors;
+ }
+
/**
* @return Row IDs associated with the topK vectors near the query
*/
- public VectorPostingList search(float[] queryVector, int topK, int limit,
Bits acceptBits)
+ public CloseableIterator<RowIdWithScore> search(float[] queryVector, int
topK, int limit, Bits acceptBits, IntConsumer nodesVisitedConsumer)
{
OnHeapGraph.validateIndexable(queryVector, similarityFunction);
+ // TODO why isn't this getting closed?
Review Comment:
What would the best approach be? Closing the `GraphSearcher` as part of
closing the `AutoResumingNodeScoreIterator`? Is there a test where this
surfaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
