michaelsembwever commented on code in PR #4555:
URL: https://github.com/apache/cassandra/pull/4555#discussion_r2681185870
##########
src/java/org/apache/cassandra/service/StartupChecks.java:
##########
@@ -155,6 +157,14 @@ public StartupChecks withDefaultTests()
return this;
}
+ public StartupChecks withExternalTests() {
Review Comment:
question: what's the value in exposing this method ?
is it solely about order versus calls to `withTest(StartupCheck)`
suggestion: rename for added intuition
```suggestion
public StartupChecks withServiceLoaderTests() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
