arvindKandpal-ksolves commented on code in PR #4412:
URL: https://github.com/apache/cassandra/pull/4412#discussion_r2682000650


##########
test/distributed/org/apache/cassandra/distributed/test/BetweenInversionTest.java:
##########
@@ -0,0 +1,36 @@
+package org.apache.cassandra.distributed.test;
+
+import org.apache.cassandra.distributed.Cluster;
+import org.apache.cassandra.distributed.api.ConsistencyLevel;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests that the BETWEEN operator respects SQL semantics:
+ * - Normal BETWEEN (low <= high) returns rows.
+ * - Inverted BETWEEN (low > high) returns no rows (empty result).
+ */
+public class BetweenInversionTest

Review Comment:
   _build-test:
       [javac] Compiling 1 source file to 
/mnt/backup_hdd/cassandra-github-code/cassandra/build/test/classes
       [javac] Note: 
/mnt/backup_hdd/cassandra-github-code/cassandra/test/distributed/org/apache/cassandra/distributed/test/BetweenInversionTest.java
 uses unchecked or unsafe operations.
       [javac] Note: Recompile with -Xlint:unchecked for details.
        [echo] Non default JDK version used: 17
   
   _check-test-names:
   [check-test-names] 17:34:35.847 [main] INFO org.reflections.Reflections -- 
Reflections took 4480 ms to scan 4 urls, producing 1384 keys and 16809 values
   [check-test-names] 17:34:40.586 [main] INFO org.reflections.Reflections -- 
Reflections took 1227 ms to scan 4 urls, producing 1384 keys and 16809 values
   
   test-jvm-dtest:
   [junit-timeout] Testsuite: 
org.apache.cassandra.distributed.test.BetweenInversionTest-_jdk17
   [junit-timeout] Testsuite: 
org.apache.cassandra.distributed.test.BetweenInversionTest-_jdk17 Tests run: 2, 
Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.131 sec
   [junit-timeout] 
   [junit-timeout] Testcase: 
initializationError(org.apache.cassandra.distributed.test.BetweenInversionTest)-_jdk17:
    Caused an ERROR
   [junit-timeout] The class 
org.apache.cassandra.distributed.test.BetweenInversionTest is not public.
   [junit-timeout] java.lang.Exception: The class 
org.apache.cassandra.distributed.test.BetweenInversionTest is not public.
   [junit-timeout]      at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
   [junit-timeout]      at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
   [junit-timeout]      at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   [junit-timeout]      at 
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
   [junit-timeout]      at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
   [junit-timeout] 
   [junit-timeout] 
   [junit-timeout] Testcase: 
initializationError(org.apache.cassandra.distributed.test.BetweenInversionTest)-_jdk17:
    Caused an ERROR
   [junit-timeout] Test class should have exactly one public constructor
   [junit-timeout] java.lang.Exception: Test class should have exactly one 
public constructor
   [junit-timeout]      at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
   [junit-timeout]      at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
   [junit-timeout]      at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   [junit-timeout]      at 
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
   [junit-timeout]      at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
   [junit-timeout] 
   [junit-timeout] 
   [junit-timeout] Test 
org.apache.cassandra.distributed.test.BetweenInversionTest FAILED
   
   BUILD FAILED
   /mnt/backup_hdd/cassandra-github-code/cassandra/build.xml:1850: The 
following error occurred while executing this line:
   /mnt/backup_hdd/cassandra-github-code/cassandra/build.xml:1732: Some test(s) 
failed.
   
   Total time: 1 minute 4 seconds
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to