aweisberg commented on code in PR #4447:
URL: https://github.com/apache/cassandra/pull/4447#discussion_r2683923168
##########
src/java/org/apache/cassandra/net/Verb.java:
##########
@@ -302,6 +317,16 @@ public enum Verb
PAXOS2_CLEANUP_COMPLETE_REQ (48, P2, repairTimeout, PAXOS_REPAIR,
() -> PaxosCleanupComplete.serializer, () ->
PaxosCleanupComplete.verbHandler,
PAXOS2_CLEANUP_COMPLETE_RSP ),
PAXOS2_UPDATE_LOW_BALLOT_RSP (67, P2, repairTimeout, PAXOS_REPAIR,
() -> NoPayload.serializer, RESPONSE_HANDLER
),
PAXOS2_UPDATE_LOW_BALLOT_REQ (64, P2, repairTimeout, PAXOS_REPAIR,
() -> PaxosUpdateLowBallot.serializer, () ->
PaxosUpdateLowBallot.verbHandler,
PAXOS2_UPDATE_LOW_BALLOT_RSP ),
+ PAXOS2_COMMIT_FORWARD_RSP (71, P2, writeTimeout, REQUEST_RESPONSE, () ->
NoPayload.serializer, RESPONSE_HANDLER
),
+ PAXOS2_COMMIT_FORWARD_REQ (72, P2, writeTimeout, MUTATION, () ->
Paxos2CommitForwardRequest.serializer, () ->
Paxos2CommitForwardHandler.instance, PAXOS2_COMMIT_FORWARD_RSP ),
+
+ // CAS and consensus read forwarding for tracked keyspaces
+ CAS_FORWARD_RSP (73, P2, writeTimeout, REQUEST_RESPONSE, () ->
CasForwardResponse.serializer, RESPONSE_HANDLER
),
+ CAS_FORWARD_REQ (74, P2, writeTimeout, MUTATION, () ->
CasForwardRequest.serializer, () -> CasForwardHandler.instance,
CAS_FORWARD_RSP ),
Review Comment:
Mutation stage is not appropriate here because we can exhaust the # of
threads and be unable to complete and it's a potentially long running operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
