Maxwell-Guo commented on code in PR #4540:
URL: https://github.com/apache/cassandra/pull/4540#discussion_r2703014417
##########
src/java/org/apache/cassandra/db/SystemKeyspace.java:
##########
@@ -373,6 +373,7 @@ private SystemKeyspace()
+ "keyspace_name text,"
+ "rows_merged map<int, bigint>,"
+ "compaction_properties frozen<map<text, text>>,"
+ + "compaction_type text,"
Review Comment:
Hi , why you add this column for table compaction_history ?
the column compaction_properties will also show the table's compaction type
too.
we can see this jira https://issues.apache.org/jira/browse/CASSANDRA-18061
The first time i add the column compaction_properties is used to show the
type of compaction task
and the column type is text too, but we changed it to a frozen map after
some discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
