omniCoder77 commented on PR #4548: URL: https://github.com/apache/cassandra/pull/4548#issuecomment-3766804100
Hey @smiklosovic, just gently ping here. I updated the PR with fixes on Jan 12 covering the missing `type` property and add proper quoting for `name` and `scope` as you pointed out. Additionally I added null-check for all three properties. The heap stats and unit tests still look solid with the change. Let me know if that addresses everything or if there's anything else I should do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
