michaelsembwever commented on code in PR #4571:
URL: https://github.com/apache/cassandra/pull/4571#discussion_r2707800111
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public class CompactionGarbageCollectOnlyPurgeRepairedTest extends CQLTester
```
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public void testAllRepaired() throws Throwable
```
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public void testSTCS() throws Throwable
```
##########
test/docker/docker-compose.yml:
##########
Review Comment:
we don't need this file, or the Dockerfile, or the README.md.
just run
```
ant jar
.build/docker/run-tests.sh -a test -t GarbageCollectRepairedSSTablesTest
````
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public void testLCS() throws Throwable
```
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public void testOnlyPurgeRepaired() throws Throwable
```
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
public void testWithoutOnlyPurgeRepaired() throws Throwable
```
##########
test/unit/org/apache/cassandra/db/compaction/GarbageCollectRepairedSSTablesTest.java:
##########
Review Comment:
nit
```suggestion
* Tests that garbage collection completes
* when there are mixed repaired and unrepaired SSTables with
only_purge_repaired_tombstones=true
*/
```
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -851,7 +688,9 @@ public Iterable<SSTableReader>
filterSSTables(LifecycleTransaction transaction)
List<SSTableReader> filteredSSTables = new ArrayList<>();
if
(cfStore.getCompactionStrategyManager().onlyPurgeRepairedTombstones())
{
- for (SSTableReader sstable : transaction.originals())
+ // Copy originals to avoid ConcurrentModificationException
when cancel()
+ // modifies the underlying collection
Review Comment:
nit
```suggestion
// Copy originals to avoid
ConcurrentModificationException when cancel()
// modifies the underlying collection when calling
`cancel(..)`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
