blambov commented on code in PR #4474:
URL: https://github.com/apache/cassandra/pull/4474#discussion_r2720438560
##########
src/java/org/apache/cassandra/db/compaction/CursorCompactor.java:
##########
@@ -636,6 +636,16 @@ private boolean mergeCells(int cellMergeLimit,
DeletionTime activeDeletion, Live
ReusableLivenessInfo cellLiveness = cellCursor.cellLiveness;
DataOutputBuffer tempCellBuffer = null;
+ if
(!metadata().regularAndStaticColumns().contains(cellCursor.cellColumn))
Review Comment:
Does this mean that the cursor path doesn't drop data that is older than the
drop time of the column?
If so, I think this is something we need to fix (i.e., in addition to this,
adjust the applicable deletion time if the column is dropped and recreated).
We should pre-compute the intersection of the table's dropped columns with
the ones in this file to avoid performing this `contains` lookup unnecessarily
(most compactions should have an empty intersection).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
