minal-kyada commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2723378585
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -583,6 +583,10 @@ public static class SSTableConfig
public volatile int tombstone_warn_threshold = 1000;
public volatile int tombstone_failure_threshold = 100000;
+ public volatile boolean write_thresholds_enabled = false;
+ public volatile DataStorageSpec.LongBytesBound write_size_warn_threshold =
null;
+ public volatile int write_tombstone_warn_threshold = -1;
Review Comment:
For **write_size_warn_threshold**:
The validation is enforced by the DataStorageSpec type itself and the
constructor validates that any non-null value must be >= 0. For this type, null
represents "disabled" (equivalent to -1 for int fields). So technically the
valid values are either **null** OR **>= 0**
I think it will be a redundant validation if I add soemthing similar to read
thresholds, what do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
