joaquincasares commented on PR #4571: URL: https://github.com/apache/cassandra/pull/4571#issuecomment-3816241157
@michaelsembwever , I've made a few changes to the PR that should be clearer now. :crossed_fingers: Essentially, I was testing that my change didn't break other more basic cases on the more often beaten path. If you want, we can definitely remove them, but I figure they would be good test cases to have for future changes in either case. Regarding the remaining three comments, I ran the same test file with and without the fix within CompactionManager.java. On the previous release, we ended up having issues only on those tests that were looking for leaks. When I applied the fix, those tests passed. testLeakDetectionWithAwaitility and testNoLeakDetectionWithAwaitility are less testing Cassandra and more testing the method of the fix to ensure that the fix was ideal. These are probably less valuable to include in the codebase, but I included them so we had them for the review at the very least. Do let me know if you want me to remove any specific test cases, since I am aware of test-bloat, but figured to include them so we had them during the review process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
