frankgh commented on code in PR #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313#discussion_r2761645136
##########
server/src/main/java/org/apache/cassandra/sidecar/lifecycle/ProcessRuntimeConfiguration.java:
##########
@@ -128,6 +128,7 @@ public ProcessBuilder buildStartCommand(String
pidFileLocation, Path stdoutFileL
startCassandraCmd.add(cassandraBin().toString());
startCassandraCmd.add("-p");
startCassandraCmd.add(pidFileLocation);
+ startCassandraCmd.add("-R"); // Allow running as root (required for
Cassandra 5.0+ when running as root)
Review Comment:
I think adding this flag to production code is dangerous. Looking at
[CASSANDRA-8142](https://issues.apache.org/jira/browse/CASSANDRA-8142) the idea
is to prevent this behavior by default for good reasons. I would propose that
we alternatively look into having the ability to provide optional extra args
that we can configure for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
