absurdfarce commented on code in PR #1264: URL: https://github.com/apache/cassandra-python-driver/pull/1264#discussion_r2767683240
########## pyproject.toml: ########## @@ -0,0 +1,57 @@ +[build-system] +build-backend = "setuptools.build_meta" +requires = ["setuptools", "Cython>=3.0", "toml", "cassandra-driver"] Review Comment: Agree that this is a change but I think it's much less significant than what Copilot describes. The user merely has to remove cython from build-system.requires in pyproject.toml to achieve the same effect. More broadly I think our old approach here is worth a rethink anyway. Using cython is the default for all builds (users have to explicitly opt out of it) and it's included for all wheel builds, so the only way a user could _avoid_ cython would be to create a custom local build and share the corresponding wheel. There's a decent argument to be made that we should remove any of the "pure Python" alternates for functionality implemented by cython and just use cython all the time. This PR is the wrong place to do that but it's something to consider. The other relevant point here is the pending move to Rust for this functionality (see [CASSPYTHON-8](https://issues.apache.org/jira/browse/CASSPYTHON-8)). A similar conversation should be had there; once we have Rust impls working I don't think it makes sense to keep the "pure Python" versions around. But again that's a conversation for the future. For now I'm comfortable saying the user can accomplish this by modifying pyproject.toml locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
