smiklosovic commented on PR #4600: URL: https://github.com/apache/cassandra/pull/4600#issuecomment-3856553289
> tpstats -F json already emits JSON, but its key ordering is > non-deterministic: the data flows through TpStatsHolder.convert2Map() > and StatsPrinter.JsonPrinter, both of which use plain HashMap. > Switching those to sorted maps would silently change the output that > existing scripts and CI pipelines already consume and may parse or diff > in an order-dependent way. I do not understand the reasoning here. If tpstats -F prints non-deterministically, what harm is done when it starts to be ordered? If it is ordered, that is the same case as if it was not intentionally ordered and it was printed out ordered by pure accident. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
