maedhroz commented on code in PR #4565:
URL: https://github.com/apache/cassandra/pull/4565#discussion_r2784617300
##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -374,7 +375,8 @@ void finishActivation(PendingLocalTransfer transfer,
TransferActivation activati
return;
// This is the only difference with finishWriting - can we
consolidate these methods?
- unreconciledMutations.activatedTransfer(activation.id(),
transfer.sstables);
+ if (bounds != null) // TODO: Is this the correct way to handle an
empty repair/sync? What bounds would we even use?
+ unreconciledMutations.activatedTransfer(activation.id(),
bounds);
Review Comment:
I think I can fix this at the same time as the `UnreconciledMutations` issue
above. Activation requests should never have empty bounds now.
##########
src/java/org/apache/cassandra/replication/CoordinatorLog.java:
##########
@@ -374,7 +375,8 @@ void finishActivation(PendingLocalTransfer transfer,
TransferActivation activati
return;
// This is the only difference with finishWriting - can we
consolidate these methods?
- unreconciledMutations.activatedTransfer(activation.id(),
transfer.sstables);
+ if (bounds != null) // TODO: Is this the correct way to handle an
empty repair/sync? What bounds would we even use?
+ unreconciledMutations.activatedTransfer(activation.id(),
bounds);
Review Comment:
Repairs already use the repair range rather than the SSTable bounds. (see
`activateLocal()`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
