smiklosovic commented on code in PR #4601:
URL: https://github.com/apache/cassandra/pull/4601#discussion_r2785876525
##########
src/java/org/apache/cassandra/schema/SystemDistributedKeyspace.java:
##########
@@ -199,13 +200,14 @@ private SystemDistributedKeyspace()
public static final String COMPRESSION_DICTIONARIES_CQL = "CREATE TABLE IF
NOT EXISTS %s (" +
"keyspace_name
text," +
"table_name
text," +
+ "table_id text,"
+
"kind text," +
"dict_id
bigint," +
"dict blob," +
"dict_length
int," +
"dict_checksum
int," +
- "PRIMARY KEY
((keyspace_name, table_name), dict_id)) " +
- "WITH CLUSTERING
ORDER BY (dict_id DESC)"; // in order to retrieve the latest dictionary; the
contract is the newer the dictionary the larger the dict_id
+ "PRIMARY KEY
((keyspace_name, table_name), table_id, dict_id)) " +
+ "WITH CLUSTERING
ORDER BY (table_id DESC, dict_id DESC)"; // in order to retrieve the latest
dictionary; the contract is the newer the dictionary the larger the dict_id
Review Comment:
but that means that we would need to specify it _every single time_. If I
just want to see what is there for keyspace / table I can't because I would
need to know table id too. We also do not need to be afraid that we would fetch
"too much" if PK is just keyspace and table, because these are retrieved in a
lightweight manner anyway and we have a way how to clear orphaned too so ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
