arvindKandpal-ksolves opened a new pull request, #4610: URL: https://github.com/apache/cassandra/pull/4610
This PR addresses a regression introduced by Cursor Compaction (CASSANDRA-20918) which caused `dtest.TestMaterializedViews.test_mv_with_default_ttl_with_flush` to fail. **Issues Identified:** 1. **Missing Expiration Check:** The `CursorCompactor.mergeRows` method was manually merging rows but failed to check if the `LivenessInfo` was expired (TTL). This caused expired rows to persist as "live" (zombie rows) in the output. 2. **Missing Garbage/Shadowing Logic:** `CursorCompactor` currently lacks the `GarbageSkipper` logic found in `CompactionIterator`. Materialized Views rely on this to handle shadowable tombstones correctly. **The Fix:** 1. Updated `CursorCompactor.mergeRows` to explicitly check `(mergedRowInfo.isExpiring() && !mergedRowInfo.isLive(nowInSec))` effectively dropping expired rows. 2. Updated `CursorCompactor.isSupported` to return `false` for Materialized Views. This forces them to use the standard `CompactionIterator` (fallback), ensuring correct shadowing behavior until `CursorCompactor` supports it. patch by Arvind Kandpal; for CASSANDRA-21152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
