netudima commented on code in PR #4624:
URL: https://github.com/apache/cassandra/pull/4624#discussion_r2823562365


##########
test/unit/org/apache/cassandra/net/MatcherResponse.java:
##########
@@ -39,6 +41,8 @@
  */
 public class MatcherResponse
 {
+    // destroyed by finalizer
+    private final Executor responseExecutor = 
Executors.newSingleThreadExecutor();

Review Comment:
   yep, let me try, the main reason why I went into this lazy direction is that 
these test MessagingService infrastructure does not have lifecycle, so do add 
the shutdown logic I have to introduce the lifecycle in all related tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to