maedhroz commented on code in PR #4561:
URL: https://github.com/apache/cassandra/pull/4561#discussion_r2833600753
##########
src/java/org/apache/cassandra/index/sai/plan/Expression.java:
##########
@@ -324,6 +324,10 @@ public boolean isSatisfiedBy(ByteBuffer columnValue)
private boolean validateStringValue(ByteBuffer columnValue, ByteBuffer
requestedValue)
{
+ if (indexTermType.isFrozenCollection() &&
+ (operator == IndexOperator.CONTAINS_VALUE || operator ==
IndexOperator.CONTAINS_KEY))
+ return termMatches(columnValue, requestedValue);
Review Comment:
I’m still not sure what this extra check for contains key and contains value
is doing. Should we reject other index operators? If the operator is fine, can
we then just fall through to the logic below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
