beobal commented on PR #4614: URL: https://github.com/apache/cassandra/pull/4614#issuecomment-3945060047
There are a handful of other new test failures, but they're easily fixable: ### InsertUpdateIfConditionTest (and friends) This test is/was partially concerned with verifying the behaviour of certain statements when the cluster is being upgraded (see CASSANDRA-16415 for details). The way that the test fixtures are setting up ClusterMetadata to perform this verification is no longer possible after the additional constraints were added to `Register` (& `Startup). I've pushed a commit [here](https://github.com/beobal/cassandra/commit/a7ba4c2d74d56574a948e269bc57aeea6f114294) which reworks the tests to acheive the same goal in a slightly different way. ### ClusterMetadataTest The failures here were in tests which assert that transformations with a min common version requirement can't be committed if the actual common version is lower. It was just the setup that was at fault as it was registering nodes with a higher version, before trying to add another with a lower version. As that is now disallowed, I just reversed the ordering, so that the node on the older version is added first. The only minor complication is that the first node becomes the sole CMS member, so assasinating it to reset the min common version isn't possible. So, instead the test now upgrades that node which ultimately has the same effect of raising the min common version. [Test fix](https://github.com/beobal/cassandra/commit/9a15fdd90a38b147fae964c2f635e32784af2c3f) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
