joao-r-reis commented on code in PR #1929:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1929#discussion_r2873994518
##########
metadata.go:
##########
@@ -2049,3 +2077,72 @@ func isIdentifierChar(c byte) bool {
c == '_' ||
c == '&'
}
+
+// Handles the full schema changes including table, user type, function,
aggregate.
+func handleFullSchemaChanges(session *Session, oldKeyspaces, newKeyspaces
map[string]*KeyspaceMetadata) {
+ session.logger.Debug("Processing full schema change",
+ NewLogFieldInt("old_keyspaces_count", len(oldKeyspaces)),
+ NewLogFieldInt("new_keyspaces_count", len(newKeyspaces)),
+ )
+
+ for _, oldKsMeta := range oldKeyspaces {
+ newKsMeta, ok := newKeyspaces[oldKsMeta.Name]
+ if !ok {
+ // Skip, KeyspaceChangeListener is already notified
+ // TODO: do we actually have to compute changes
following java-driver approach?
Review Comment:
We're not calling it on the hot path of a request so it should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
