tolbertam commented on PR #4558:
URL: https://github.com/apache/cassandra/pull/4558#issuecomment-4023882998

   sounds good :+1:.  I'm having trouble running the upgrade python-dtests but 
everything else looking good other than the issue with the dtests missing the 
system property that I mentioned in the review.  I think assuming that gets 
fixed up we should be all set.  A final rebase would be good too, there's one 
new unit test failing 
(`CompactionTaskTest#testFullyExpiredSSTablesAreNotReleasedPrematurely`) that 
was added on 5.0 that addresses a fixed issue on cassandra-5.0 that this branch 
doesn't have yet.   It'd be great to get a clean test run (other than known 
flakes) if we can.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to