absurdfarce commented on PR #4653: URL: https://github.com/apache/cassandra/pull/4653#issuecomment-4070790190
I'm okay with this change but isn't there a decent argument for moving the current impls of the escape and dequote functions from the Cql3ParsingRuleSet subclass and back into the CqlParsingRuleSet superclass? The rules around escaping and quoting are much less likely to change between CQL versions (or at least it seems that way) so a default impl that covers most (all?) CQL versions would seem a reasonable candidate for the parent class. Rule set impls for individual CQL versions could then change if these rules around quoting _did_ change in the future. Again, I'm not necessarily arguing that we _have_ to make such a change... I'm fine with moving this forward as it stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
