SiyaoIsHiding commented on code in PR #2063:
URL:
https://github.com/apache/cassandra-java-driver/pull/2063#discussion_r3031249521
##########
pom.xml:
##########
@@ -882,7 +899,49 @@ limitations under the License.]]></inlineHeader>
<useStandardDocletOptions>false</useStandardDocletOptions>
</configuration>
</execution>
+ <execution>
+ <!-- Generate aggregated Javadoc for specified modules -->
+ <id>aggregate-javadoc</id>
+ <goals>
+ <goal>aggregate</goal>
+ </goals>
+ <phase>site</phase>
+ <configuration>
+ <includeDependencySources>false</includeDependencySources>
+ <dependencySourceIncludes>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-core</dependencySourceInclude>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-query-builder</dependencySourceInclude>
+
<dependencySourceInclude>org.apache.cassandra:java-driver-mapper-runtime</dependencySourceInclude>
+ </dependencySourceIncludes>
+ <reactorProjects>
+ <reactorProject>core</reactorProject>
+ <reactorProject>query-builder</reactorProject>
+ <reactorProject>mapper-runtime</reactorProject>
+ </reactorProjects>
+ <doctitle>Apache Cassandra Java Driver ${project.version}
API</doctitle>
+ <bottom><![CDATA[
+ Copyright © {inceptionYear}–{currentYear} <a
href="https://www.apache.org/">The Apache Software Foundation</a>. All rights
reserved.
+ ]]></bottom>
+ </configuration>
+ </execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_annotations</artifactId>
+ <version>2.3.4</version>
+ </dependency>
+ <dependency>
+ <groupId>com.github.stephenc.jcip</groupId>
+ <artifactId>jcip-annotations</artifactId>
+ <version>1.0-1</version>
+ </dependency>
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-annotations</artifactId>
Review Comment:
I met failure to run `mvn javadoc:aggregate`, but it seems like running `mvn
clean install -DskipTests` beforehand resolved this problem. Removed the
unnecessary dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]