alanwang67 commented on code in PR #4692:
URL: https://github.com/apache/cassandra/pull/4692#discussion_r3053995119
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -795,22 +828,37 @@ public AllSSTableOpStatus performCleanup(final
ColumnFamilyStore cfStore, int jo
return parallelAllSSTableOperation(cfStore, new OneSSTableOperation()
{
+ boolean incompleteOperation = false;
+
@Override
public Iterable<SSTableReader> filterSSTables(LifecycleTransaction
transaction)
{
List<SSTableReader> sortedSSTables =
Lists.newArrayList(transaction.originals());
Iterator<SSTableReader> sstableIter =
sortedSSTables.iterator();
int totalSSTables = 0;
int skippedSStables = 0;
+ int sstablesInUseByAccord = 0;
while (sstableIter.hasNext())
{
SSTableReader sstable = sstableIter.next();
boolean needsCleanupFull = needsCleanup(sstable,
fullRanges);
boolean needsCleanupTransient = !transientRanges.isEmpty()
&& sstable.isRepaired() && needsCleanup(sstable, transientRanges);
+ totalSSTables++;
+
+ if
(sstableContainsRangesNeededByAccord(cfStore.getTableId(), sstable))
Review Comment:
I see, I think what I will do instead is to just add the range that Accord
is using to the full range. This way when cleanup is done we will still remove
ranges from the SSTables even if Accord partially owns a piece of it and we can
just remove this if statement all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
